Skip to content

Improve TestBuildInfoPluginFuncTest #128322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 23, 2025
Merged

Improve TestBuildInfoPluginFuncTest #128322

merged 9 commits into from
May 23, 2025

Conversation

@prdoyle
Copy link
Contributor

@prdoyle prdoyle commented May 22, 2025

  • Refactor extractModuleNameFromDirectory to call walkFileTree
  • Test dependencies in TestBuildInfoPluginFuncTest

@prdoyle prdoyle self-assigned this May 22, 2025
@prdoyle prdoyle requested a review from a team as a code owner May 22, 2025 15:39
@prdoyle prdoyle added >test Issues or PRs that are addressing/adding tests test-windows Trigger CI checks on Windows auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels May 22, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label May 22, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 22, 2025

Pinging @elastic/es-core-infra (Team:Core/Infra)

jdconrad
jdconrad approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prdoyle prdoyle enabled auto-merge (squash) May 22, 2025 15:44
@prdoyle
Copy link
Contributor Author

prdoyle commented May 22, 2025

Hopefully #128316 does the trick.

@prdoyle
Copy link
Contributor Author

prdoyle commented May 22, 2025

The failure here is unrelated to my change. I've made #128340 for that.

@prdoyle
Copy link
Contributor Author

prdoyle commented May 23, 2025

Latest failure is fixed upstream I think.


TestBuildInfoPluginFuncTest > basic functionality FAILED
--
  | org.spockframework.runtime.SpockComparisonFailure at TestBuildInfoPluginFuncTest.groovy:63

@prdoyle
Copy link
Contributor Author

prdoyle commented May 23, 2025

Hmm, maybe not.

"representative_class", "com/example/Example.class"

@prdoyle
Copy link
Contributor Author

prdoyle commented May 23, 2025

Aha, I had not set this PR to auto-merge.

@prdoyle prdoyle mentioned this pull request May 23, 2025
Merged
@prdoyle prdoyle disabled auto-merge May 23, 2025 14:01
@prdoyle prdoyle enabled auto-merge (squash) May 23, 2025 14:15
@prdoyle prdoyle mentioned this pull request May 23, 2025
Closed
@prdoyle
Standardize on forward slashes for representative_class.
7473692 
Turns out even on Windows, jar entries use forward slashes.
Let's be consistent in all cases.
@prdoyle prdoyle merged commit 13a0e97 into elastic:main May 23, 2025
23 checks passed
prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request May 23, 2025
@prdoyle
Improve TestBuildInfoPluginFuncTest (elastic#128322)
b445548 
* Use walkFileTree for extractModuleNameFromDirectory

* More tests in TestBuildInfoPluginFuncTest

* Remove stray line from debugging

* [CI] Auto commit changes from spotless

* Eliminate List.reversed() call

---------

Co-authored-by: elasticsearchmachine <[email protected]>
@prdoyle prdoyle mentioned this pull request May 23, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 23, 2025

💚 Backport successful

Status Branch Result
✅ 8.19

elasticsearchmachine pushed a commit that referenced this pull request May 23, 2025
@prdoyle @ldematte
[8.19] Improve TestBuildInfoPluginFuncTest (#128322) (#128406)
6852417 
* Improve TestBuildInfoPluginFuncTest (#128322)

* Use walkFileTree for extractModuleNameFromDirectory

* More tests in TestBuildInfoPluginFuncTest

* Remove stray line from debugging

* [CI] Auto commit changes from spotless

* Eliminate List.reversed() call

---------

Co-authored-by: elasticsearchmachine <[email protected]>

* Fix the Text class package change in example plugins (#128316)

---------

Co-authored-by: elasticsearchmachine <[email protected]>
Co-authored-by: Lorenzo Dematté <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdconrad jdconrad jdconrad approved these changes

Assignees

@prdoyle prdoyle

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests test-windows Trigger CI checks on Windows v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prdoyle @elasticsearchmachine @jdconrad